Skip to content

handle gen_tcp:recv() HttpError response (improperly) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rflynn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

handle gen_tcp:recv() HttpError response (improperly) #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/lhttpc_client.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,10 @@ read_response(State, Vsn, {StatusCode, _} = Status, Hdrs) ->
ReqHdrs = State#client_state.request_headers,
NewSocket = maybe_close_socket(Socket, Ssl, Vsn, ReqHdrs, NewHdrs),
{Response, NewSocket};
{ok, {http_error, _HttpString}} ->
% gen_tcp:recv() returns HttpError: http://www.erlang.org/doc/man/erlang.html#decode_packet-3
% XXX: not sure what the best action is, ignoring it works for me(!)
read_response(State, Vsn, Status, Hdrs);
{error, closed} ->
% Either we only noticed that the socket was closed after we
% sent the request, the server closed it just after we put
Expand Down