Skip to content

Conversation

@douglascoenen
Copy link

Added the dictionary and json file for the Thermo-Fischer Neptune Plus instrument.
Also modified the latools.cfg to add the config files under the config name: "NEPTUNE".

@oscarbranson
Copy link
Owner

Thanks very much for your input, @douglascoenen!

Quick question: how confident are you that this file format is universal for all Neptunes? If there's a chance it might vary, could you rename your config entry and dataformat file to be institute-specific? For example, see how the 'ANU-iCAP-RQ' file is named. This will avoid potential confusion later.

@douglascoenen
Copy link
Author

douglascoenen commented Dec 2, 2020

My pleasure!
I have absolutely no idea about this, I will ask around my institute, especially the technicians, if there are some differences.
Actually, there is a small mistake in the regex for the column_id. I realised that the one that I just submitted does is for "Mass Name" followed by "Mass Number", but the raw Neptune plus output is actually the reverse. I know you have a small function to reverse it, but I am just better off changing it manually here.
I will change the name to NP_GU, is that better?
I will submit the changes to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants