fix: tapping active mode segment incorrectly switches to opposite mode#641
Open
RaajeevChandran wants to merge 2 commits intoosaurus-ai:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Chat/Work mode toggle was firing a single toggle action on any tap, which always switched to the opposite mode regardless of which segment was tapped. Each segment now reports its own
Modeback through the action closure and the caller guards against switching when the tapped mode is already activeChanges
Test Plan
Screenshots
Before
Before.mov
After
After.mov
Checklist
CONTRIBUTING.md