Skip to content

Fill necessary content for passing workflow tests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osama2kabdullah merged 6 commits into from
May 31, 2025
Merged

Fill necessary content for passing workflow tests #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d25640b
adding some content
osama2kabdullah May 31, 2025
3d6dacf
added test content
osama2kabdullah May 31, 2025
1851d43
put password form into main-password-header.liquid
osama2kabdullah May 31, 2025
92fd071
add test content within gift_card.liquid
osama2kabdullah May 31, 2025
8690613
added theme check job within lighthouse-ci.yml
osama2kabdullah May 31, 2025
23f68f4
added permission for check and content read in jobs lighthouse-ci.yml
osama2kabdullah May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/lighthouse-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
name: Shopify Lighthouse CI
on: [push]

permissions:
checks: write
contents: read

jobs:
lhci:
name: Lighthouse
Expand All @@ -12,4 +17,15 @@ jobs:
access_token: ${{ secrets.SHOP_ACCESS_TOKEN }}
store: ${{ secrets.SHOP_STORE }}
password: ${{ secrets.SHOP_PASSWORD }}
collection_handle: all
lhci_github_app_token: ${{ secrets.LHCI_GITHUB_APP_TOKEN }}

theme-check:
name: Theme Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Theme Check
uses: shopify/theme-check-action@v2
with:
token: ${{ github.token }}
1 change: 1 addition & 0 deletions layout/password.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
{% section 'main-password-header' %}

<main>
<p>Test content</p>
{{ content_for_layout }}
</main>
<footer>
Expand Down
1 change: 1 addition & 0 deletions layout/theme.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
{% sections 'header-group' %}

<main>
<p>Test Content</p>
{{ content_for_layout }}
</main>

Expand Down
12 changes: 12 additions & 0 deletions sections/main-password-header.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{% form 'storefront_password' %}
{{ form.errors | default_errors }}

<div class="password">
<label for="password">Password</label>
<input type="password" name="password">
</div>

<div class="submit">
<input type="submit" value="Sign in">
</div>
{% endform %}
6 changes: 4 additions & 2 deletions templates/gift_card.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
</head>

<body class="gradient gift-card">
<main></main>
<main>
<p>Test Content</p>
</main>
</body>
</html>
</html>