Use array flip + array keys to check no duplicate category ID exists

[acidvertigo]

No description provided.

[gadlol]

I dont think this is good because it breaks code. when you use return statement nothing will be executed after that. So we need $cPath_array so to check later and return the $tmp_array.

Of course, that function can be improved be replacing sizeof (which is an alias of count) with count and change the for loop including $n=count($cPath_array) or even use foreach loop.

[acidvertigo]

As this function is called from application top on:

398      $cPath_array = tep_parse_category_path($cPath);
399     $cPath = implode('_', $cPath_array);
400     $current_category_id = $cPath_array[(sizeof($cPath_array)-1)];

and its purpose is only to convert all $cPath elements to integer make sense to me return directly the reworked $cPath array from the function.

[gadlol]

What about:

// make sure no duplicate category IDs exist which could lock the server in a loop

[acidvertigo]

Yes, now I understand you are right.

Just left unchanged previous code and added array unique to this commit that makes the same thing

[acidvertigo]

Changed to array flip method as it is faster