-
Notifications
You must be signed in to change notification settings - Fork 54
Adding testing script/environment #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
edy131109
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great but please don't commit out, out.asm and out.o.
|
Good shout, have removed |
edy131109
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
|
Would it not be worth adding files such as |
That would be something @orosmatthew could add in the next video. You could suggest it in a new issue |
|
Submit your pull request to my fork ApplePieCodes/hydrogen-cpp. The original seems to have stopped accepting them |
timomen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, also good for other people when they clone it and want to make changes.
I created a simple test script that you could use to automate testing, ensuring you don't make any breaking changes etc. Checks both exit code and (optionally) stdout when you get to that stage.