Skip to content

Conversation

@joshuawills
Copy link

I created a simple test script that you could use to automate testing, ensuring you don't make any breaking changes etc. Checks both exit code and (optionally) stdout when you get to that stage.

Copy link

@edy131109 edy131109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great but please don't commit out, out.asm and out.o.

@joshuawills
Copy link
Author

Good shout, have removed

Copy link

@edy131109 edy131109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@BenMcAvoy
Copy link

Would it not be worth adding files such as out, out.asm, out.o to the gitignore so that they are just never uploaded or even considered by git?

@zedritsch
Copy link

Would it not be worth adding files such as out, out.asm, out.o to the gitignore so that they are just never uploaded or even considered by git?

That would be something @orosmatthew could add in the next video. You could suggest it in a new issue

@ApplePieCodes
Copy link

Submit your pull request to my fork ApplePieCodes/hydrogen-cpp. The original seems to have stopped accepting them

Copy link

@timomen timomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, also good for other people when they clone it and want to make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants