fix(cli): show matched hash in query plain and table output#27
fix(cli): show matched hash in query plain and table output#27
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (3)src/cli/**/*.rs📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/**/*.rs📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/{config,cli}/**/*.rs📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (6)📚 Learning: 2026-03-02T10:47:34.685ZApplied to files:
📚 Learning: 2026-03-02T10:47:34.685ZApplied to files:
📚 Learning: 2026-03-02T10:47:34.685ZApplied to files:
📚 Learning: 2026-03-02T10:47:34.685ZApplied to files:
📚 Learning: 2026-03-02T10:47:34.685ZApplied to files:
📚 Learning: 2026-03-02T10:46:08.851ZApplied to files:
🔇 Additional comments (3)
📝 WalkthroughWalkthroughAdded hash display across all query output formats. The hash is now shown as hex in plain text output, included as a JSON field, and displayed as the first column in table output. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Comment |
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Low-risk CLI output formatting change to include matched hashes in plain and table views, improving UX without impacting core logic.
Plain format was printing just the preimage, algorithm and sources - but not the actual hash that matched. When querying by prefix, there's no way to tell which full hash corresponds to which result.
Before:
password (sha256, rockyou)After:
5e884898da28047151d0e56f8dc6292773603d0d6aabbdd62a11ef721d1542d8 password sha256 (rockyou)Also added the hash column to table format for consistency. JSON format already included it.
Closes #18