Open
Conversation
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Adding support for a new blockchain (Decred) involves external API integration and business logic changes that require human validation.
Architecture diagram
sequenceDiagram
participant C as Caller
participant B as balance::fetch
participant D as dcrdata API (External)
C->>B: fetch(address, Chain::Decred)
B->>D: NEW: GET /api/address/{address}/totals
alt Success (200 OK)
D-->>B: { dcr_unspent: f64 }
B->>B: NEW: Convert DCR to atomic units (f64 * 10^8)
B-->>C: Ok(Balance)
else Invalid Address (400 or 422)
D-->>B: Error Status
Note over B: CHANGED: is_invalid_address_status() helper
B-->>C: Err(BalanceError::InvalidAddress)
else Connection/Server Error
D-->>B: Request Failure
B-->>C: Err(BalanceError::Request)
end
Note over B,D: Also updates fetch_mempool_compatible to use 422 check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This finishes the remaining Decred half of #117.
Verification
Closes #117.