fix: remove resource leak when modify is not allowed#2282
Open
steff-o wants to merge 1 commit intoorigo-map:masterfrom
Open
fix: remove resource leak when modify is not allowed#2282steff-o wants to merge 1 commit intoorigo-map:masterfrom
steff-o wants to merge 1 commit intoorigo-map:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2281
Function
isActive()from editHandler prevented interactions from being removed if there was no modify interaction. Turns out the function didn't actually do anything useful as it checked for undefined, and clearing interactions resets them to null, so it always returned true after the first edit session even if it was not. There was already a FIXME comment for that in the code.Instead of fixing
isActive()I removed it and rewroteremoveInteractions()to always remove all interactions as that can never fail anyway, so no need to test.Also removed a double usage of variable
snapas that was temporarily used as bool at startup which causedremoveInteractions()to crash if not checked for active the first time.