Feature: Let the user set custom scales when printing#2254
Merged
Grammostola merged 5 commits intoorigo-map:masterfrom Dec 8, 2025
Merged
Feature: Let the user set custom scales when printing#2254Grammostola merged 5 commits intoorigo-map:masterfrom
Grammostola merged 5 commits intoorigo-map:masterfrom
Conversation
Collaborator
There was a problem hiding this comment.
Works, but crashes opening print when "userDefinedScale": true option isn't set in config:
set-scale-control.js:96 Uncaught TypeError: Cannot read properties of undefined (reading 'render')
at Object.render (set-scale-control.js:96:1)
at printTemplate (print-settings.template.js:33:1)
at Object.render (print-settings.js:203:1)
at Object.render (collapse.js:135:1)
at Object.render (print-settings.js:268:1)
at Object.render (print-component.js:728:1)
at Object.click (index.js:162:1)
at eval (eventer.js:20:1)
at Array.forEach (<anonymous>)
at Object.dispatch (eventer.js:20:1)
Collaborator
johnnyblasta
left a comment
johnnyblasta
left a comment
There was a problem hiding this comment.
Don't really like the swedish language for "userDefinedScale": "Mata in egen skala" would prefer for example "userDefinedScale": "Ange din egen skala:"
Flodkvist
added
the
Awaiting documentation
Contributor
Author
|
Changed the text to JohnnyBlasta's suggestion and added documentation here |
johnnyblasta
removed
the
Awaiting documentation
johnnyblasta
added
the
PR approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the feature described in #2239
If the print control option "userDefinedScale" is true a user can now input any scale they wish, with the constraint that it's within the min-max resolution of the map (similar to #1938)