Skip to content

Conversation

@Xyon
Copy link
Member

@Xyon Xyon commented Jan 1, 2025

No description provided.

@n7275
Copy link
Contributor

n7275 commented Jan 23, 2025

@Xyon is this ready to be tested/merged?

@Xyon
Copy link
Member Author

Xyon commented Jan 26, 2025

@Xyon is this ready to be tested/merged?

No, not yet. The PR was just to get it to run the actions for testing - the x64 debug build is not successful from this branch atm.

@GLS-SSV
Copy link
Contributor

GLS-SSV commented Jan 27, 2025

So this produces a release package and a debug package? Can't only one package be created with both lib types? Orbitersdk.lib and OrbitersdkD.lib

@Xyon
Copy link
Member Author

Xyon commented Feb 4, 2025

So this produces a release package and a debug package? Can't only one package be created with both lib types? Orbitersdk.lib and OrbitersdkD.lib

My CMake skills have not yet got to the point where I know how to make it do that, but I would generally prefer that approach than a whole separated release, yes. For the O2024-compatible version, though, we can repackage the release but it might be well to offer a smaller "debug libs only" package for those who don't want to download the whole ~2.4GB package again just to get the debug libs.

@GLS-SSV
Copy link
Contributor

GLS-SSV commented Feb 12, 2025

This solution of separate packages, from the point of view of the developer, is a PITA: either we'll need 2 separate environments with the same addon code (not practical), or we'll to have a new folder for the libs and manually copy the them to there, or rename the libs to keep all of them together (updating is error-prone).

This might help to put all in one package with different names: https://cmake.org/cmake/help/latest/guide/tutorial/Packaging%20Debug%20and%20Release.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants