Improve connecting/disconnecting of Saturn/launchpad umbilical classes in various cases like pad aborts or vessels being deleted #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in various cases like pad aborts or vessels being deleted
indy91
requested review from
CaptainSwag101,
ThatRedMelon,
maxq519,
n7275 and
rcflyinghokie
ThatRedMelon
approved these changes
Aug 10, 2025
Contributor
ThatRedMelon
left a comment
ThatRedMelon
left a comment
There was a problem hiding this comment.
The sim doesn't crash in O16 and O24, as expected
rcflyinghokie
approved these changes
Aug 10, 2025
Collaborator
rcflyinghokie
left a comment
rcflyinghokie
left a comment
There was a problem hiding this comment.
No crashes here in OO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the connecting/disconnecting behavior of the umbilical classes for the IU, S-IB and S-IC to work more like our general connector class.
The reason for this change is an (apparent) different deletion order of vessels in Open Orbiter which causes a crash of the simulation on exiting it. This PR also deletes some special code handling pad aborts where the disconnection of the umbilical isn't caused as usual by a call of the Disconnect function. With this change the order of deletion of the umbilical/systems classes and the source of the disconnect should not matter at all.
Testing for this PR should all be possible with scenarios shortly before launch. If the Saturn launches normally then the umbilical connect (on scenario load) works correctly. Disconnects can be tested with normal launches and pad aborts. There should be no crash on scenario exit. There wasn't any crash in the Orbiter Beta anyway. This PR is mostly for Open Orbiter and a good cleanup of some bad workarounds.
This change is also mostly temporary as the WIP branch for Saturn V docked stages (#1382) actually changes the umbilicals to use the connector class.