Support embeding LiveView inside react#379
Draft
Baradoy wants to merge 2 commits intoshop_admin_liveview_barebonesfrom
Draft
Support embeding LiveView inside react#379Baradoy wants to merge 2 commits intoshop_admin_liveview_barebonesfrom
Baradoy wants to merge 2 commits intoshop_admin_liveview_barebonesfrom
Conversation
Baradoy
force-pushed
the
shop_admin_liveview_embeded
branch
2 times, most recently
from
53ba855 to
bd89a49
Compare
hez
force-pushed
the
shop_admin_liveview_barebones
branch
2 times, most recently
from
0fe058b to
dab8141
Compare
hez
force-pushed
the
shop_admin_liveview_barebones
branch
from
dab8141 to
c112f5e
Compare
hez
force-pushed
the
shop_admin_liveview_barebones
branch
from
c112f5e to
d24ef51
Compare
It is not entirely clear why the plug does not work in a pipeline, but it does not. Likely this is related to how the macro for liveviews works
hez
force-pushed
the
shop_admin_liveview_embeded
branch
from
d41ffd4 to
96d21d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds embeded_shop_admin and embeded_shop_admin.js which allow embeding a liveview inside of of a react component.
See this PR for something that consumes this: https://github.com/orbit-apps/lv-shopify-app/pull/7