Open
Conversation
I was not able to enter my California license plate number because the pattern was too restrictive. :)
Collaborator
|
Thanks :) I know it's a small change but did you/can you sign the CLA? |
Author
|
Sorry, my employer, being primarily in the business of intellectual property, is very reluctant to sign CLAs on my behalf. |
Collaborator
|
I understand. This said, there is an Individual Contributor License Agreement too. |
Author
|
Yes. If I had done this on my free time, I would sign the ICLA. |
Owner
|
No problem. Again I realize it's a small change and it looks overkill and we appreciate the contribution, but we have to get a CLA for everything. What about this: can you give me an example of a license plate number that fails, and I'll get somebody else to do the fix without looking at this PR, which I will close without merging. |
Author
|
Any plate with a zero in it. |
ebruchez
force-pushed
the
master
branch
3 times, most recently
from
62217d7 to
7da8e3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was not able to enter my California license plate number because the pattern was too restrictive. 😁