Skip to content

Commit b33a931

Browse files
fix(client): bad deserialize call for void method
1 parent d4f5c97 commit b33a931

File tree

4 files changed

+17
-41
lines changed

4 files changed

+17
-41
lines changed

src/Orb/Services/CreditBlockService.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,12 @@ public Task<CreditBlockRetrieveResponse> Retrieve(
5959
}
6060

6161
/// <inheritdoc/>
62-
public async Task Delete(
62+
public Task Delete(
6363
CreditBlockDeleteParams parameters,
6464
CancellationToken cancellationToken = default
6565
)
6666
{
67-
using var response = await this
68-
.WithRawResponse.Delete(parameters, cancellationToken)
69-
.ConfigureAwait(false);
70-
return await response.Deserialize(cancellationToken).ConfigureAwait(false);
67+
return this.WithRawResponse.Delete(parameters, cancellationToken);
7168
}
7269

7370
/// <inheritdoc/>

src/Orb/Services/CustomerService.cs

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -105,15 +105,12 @@ public async Task<CustomerListPage> List(
105105
}
106106

107107
/// <inheritdoc/>
108-
public async Task Delete(
108+
public Task Delete(
109109
CustomerDeleteParams parameters,
110110
CancellationToken cancellationToken = default
111111
)
112112
{
113-
using var response = await this
114-
.WithRawResponse.Delete(parameters, cancellationToken)
115-
.ConfigureAwait(false);
116-
return await response.Deserialize(cancellationToken).ConfigureAwait(false);
113+
return this.WithRawResponse.Delete(parameters, cancellationToken);
117114
}
118115

119116
/// <inheritdoc/>
@@ -184,15 +181,12 @@ parameters with
184181
}
185182

186183
/// <inheritdoc/>
187-
public async Task SyncPaymentMethodsFromGateway(
184+
public Task SyncPaymentMethodsFromGateway(
188185
CustomerSyncPaymentMethodsFromGatewayParams parameters,
189186
CancellationToken cancellationToken = default
190187
)
191188
{
192-
using var response = await this
193-
.WithRawResponse.SyncPaymentMethodsFromGateway(parameters, cancellationToken)
194-
.ConfigureAwait(false);
195-
return await response.Deserialize(cancellationToken).ConfigureAwait(false);
189+
return this.WithRawResponse.SyncPaymentMethodsFromGateway(parameters, cancellationToken);
196190
}
197191

198192
/// <inheritdoc/>
@@ -215,18 +209,15 @@ parameters with
215209
}
216210

217211
/// <inheritdoc/>
218-
public async Task SyncPaymentMethodsFromGatewayByExternalCustomerID(
212+
public Task SyncPaymentMethodsFromGatewayByExternalCustomerID(
219213
CustomerSyncPaymentMethodsFromGatewayByExternalCustomerIDParams parameters,
220214
CancellationToken cancellationToken = default
221215
)
222216
{
223-
using var response = await this
224-
.WithRawResponse.SyncPaymentMethodsFromGatewayByExternalCustomerID(
225-
parameters,
226-
cancellationToken
227-
)
228-
.ConfigureAwait(false);
229-
return await response.Deserialize(cancellationToken).ConfigureAwait(false);
217+
return this.WithRawResponse.SyncPaymentMethodsFromGatewayByExternalCustomerID(
218+
parameters,
219+
cancellationToken
220+
);
230221
}
231222

232223
/// <inheritdoc/>

src/Orb/Services/Customers/Credits/TopUpService.cs

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,9 @@ public Task<TopUpListPage> List(
8181
}
8282

8383
/// <inheritdoc/>
84-
public async Task Delete(
85-
TopUpDeleteParams parameters,
86-
CancellationToken cancellationToken = default
87-
)
84+
public Task Delete(TopUpDeleteParams parameters, CancellationToken cancellationToken = default)
8885
{
89-
using var response = await this
90-
.WithRawResponse.Delete(parameters, cancellationToken)
91-
.ConfigureAwait(false);
92-
return await response.Deserialize(cancellationToken).ConfigureAwait(false);
86+
return this.WithRawResponse.Delete(parameters, cancellationToken);
9387
}
9488

9589
/// <inheritdoc/>
@@ -132,15 +126,12 @@ parameters with
132126
}
133127

134128
/// <inheritdoc/>
135-
public async Task DeleteByExternalID(
129+
public Task DeleteByExternalID(
136130
TopUpDeleteByExternalIDParams parameters,
137131
CancellationToken cancellationToken = default
138132
)
139133
{
140-
using var response = await this
141-
.WithRawResponse.DeleteByExternalID(parameters, cancellationToken)
142-
.ConfigureAwait(false);
143-
return await response.Deserialize(cancellationToken).ConfigureAwait(false);
134+
return this.WithRawResponse.DeleteByExternalID(parameters, cancellationToken);
144135
}
145136

146137
/// <inheritdoc/>

src/Orb/Services/InvoiceService.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,15 +84,12 @@ public async Task<InvoiceListPage> List(
8484
}
8585

8686
/// <inheritdoc/>
87-
public async Task DeleteLineItem(
87+
public Task DeleteLineItem(
8888
InvoiceDeleteLineItemParams parameters,
8989
CancellationToken cancellationToken = default
9090
)
9191
{
92-
using var response = await this
93-
.WithRawResponse.DeleteLineItem(parameters, cancellationToken)
94-
.ConfigureAwait(false);
95-
return await response.Deserialize(cancellationToken).ConfigureAwait(false);
92+
return this.WithRawResponse.DeleteLineItem(parameters, cancellationToken);
9693
}
9794

9895
/// <inheritdoc/>

0 commit comments

Comments
 (0)