refactor(client): add JsonDictionary identity methods

Author: stainless-app[bot]

src/Orb.Tests/Core/JsonDictionaryTest.cs

@@ -331,4 +331,76 @@ public void ComplexWorkflow_SetFreezeAndGet()
 
         Assert.Throws<InvalidOperationException>(() => dict.Set("new", "value"));
     }
+
+    [Fact]
+    public void ToString_ContainsJsonValues()
+    {
+        var dict = new JsonDictionary();
+        dict.Set("name", "Alice");
+        dict.Set("age", 30);
+
+        var json = dict.ToString();
+
+        Assert.Contains("\"name\"", json);
+        Assert.Contains("\"Alice\"", json);
+        Assert.Contains("\"age\"", json);
+        Assert.Contains("30", json);
+    }
+
+    [Fact]
+    public void Equals_ReturnsTrueForSameContent()
+    {
+        var dict1 = new JsonDictionary();
+        dict1.Set("name", "Alice");
+        dict1.Set("age", 30);
+
+        var dict2 = new JsonDictionary();
+        dict2.Set("name", "Alice");
+        dict2.Set("age", 30);
+
+        Assert.True(dict1.Equals(dict2));
+    }
+
+    [Fact]
+    public void Equals_ReturnsFalseForDifferentContent()
+    {
+        var dict1 = new JsonDictionary();
+        dict1.Set("name", "Alice");
+
+        var dict2 = new JsonDictionary();
+        dict2.Set("name", "Bob");
+
+        Assert.False(dict1.Equals(dict2));
+    }
+
+    [Fact]
+    public void Equals_ReturnsFalseForDifferentCounts()
+    {
+        var dict1 = new JsonDictionary();
+        dict1.Set("name", "Alice");
+        dict1.Set("age", 30);
+
+        var dict2 = new JsonDictionary();
+        dict2.Set("name", "Alice");
+
+        Assert.False(dict1.Equals(dict2));
+    }
+
+    [Fact]
+    public void Equals_ReturnsFalseForNull()
+    {
+        var dict = new JsonDictionary();
+        dict.Set("name", "Alice");
+
+        Assert.False(dict.Equals(null));
+    }
+
+    [Fact]
+    public void Equals_ReturnsFalseForDifferentType()
+    {
+        var dict = new JsonDictionary();
+        dict.Set("name", "Alice");
+
+        Assert.False(dict.Equals("not a dictionary"));
+    }
 }

src/Orb/Core/JsonDictionary.cs

@@ -44,7 +44,6 @@ public JsonDictionary()
     public JsonDictionary(IReadOnlyDictionary<string, JsonElement> dictionary)
     {
         _rawData = Enumerable.ToDictionary(dictionary, (e) => e.Key, (e) => e.Value);
-        ;
         _deserializedData = [];
     }
 
@@ -57,7 +56,6 @@ public JsonDictionary(FrozenDictionary<string, JsonElement> dictionary)
     public JsonDictionary(JsonDictionary dictionary)
     {
         _rawData = Enumerable.ToDictionary(dictionary._rawData, (e) => e.Key, (e) => e.Value);
-        ;
         _deserializedData = new(dictionary._deserializedData);
     }
 
@@ -186,4 +184,35 @@ public T GetNotNullStruct<T>(string key)
         _deserializedData[key] = deserialized;
         return deserialized;
     }
+
+    public override string ToString() =>
+        JsonSerializer.Serialize(this._rawData, ModelBase.ToStringSerializerOptions);
+
+    public override bool Equals(object? obj)
+    {
+        if (obj is not JsonDictionary other || _rawData.Count != other._rawData.Count)
+        {
+            return false;
+        }
+
+        foreach (var item in _rawData)
+        {
+            if (!other._rawData.TryGetValue(item.Key, out var otherValue))
+            {
+                return false;
+            }
+
+            if (!JsonElement.DeepEquals(item.Value, otherValue))
+            {
+                return false;
+            }
+        }
+
+        return true;
+    }
+
+    public override int GetHashCode()
+    {
+        return 0;
+    }
 }

src/Orb/Core/JsonModel.cs

@@ -12,12 +12,6 @@ public abstract record class JsonModel : ModelBase
 {
     private protected JsonDictionary _rawData = new();
 
-    protected JsonModel(JsonModel jsonModel)
-        : base(jsonModel)
-    {
-        this._rawData = new(jsonModel._rawData);
-    }
-
     /// <summary>
     /// The backing JSON properties of the instance.
     /// </summary>
@@ -26,36 +20,25 @@ public IReadOnlyDictionary<string, JsonElement> RawData
         get { return this._rawData.Freeze(); }
     }
 
-    public sealed override string ToString() =>
-        JsonSerializer.Serialize(this.RawData, ModelBase.ToStringSerializerOptions);
+    protected JsonModel(JsonModel jsonModel)
+        : base(jsonModel)
+    {
+        this._rawData = new(jsonModel._rawData);
+    }
+
+    public sealed override string ToString() => this._rawData.ToString();
 
     public virtual bool Equals(JsonModel? other)
     {
-        if (other == null || this.RawData.Count != other.RawData.Count)
+        if (other == null)
         {
             return false;
         }
 
-        foreach (var item in this.RawData)
-        {
-            if (!other.RawData.TryGetValue(item.Key, out var otherValue))
-            {
-                return false;
-            }
-
-            if (!JsonElement.DeepEquals(item.Value, otherValue))
-            {
-                return false;
-            }
-        }
-
-        return true;
+        return this._rawData.Equals(other._rawData);
     }
 
-    public override int GetHashCode()
-    {
-        return 0;
-    }
+    public override int GetHashCode() => this._rawData.GetHashCode();
 }
 
 /// <summary>

src/Orb/Core/MultipartJsonDictionary.cs

@@ -44,7 +44,6 @@ public MultipartJsonDictionary()
     public MultipartJsonDictionary(IReadOnlyDictionary<string, MultipartJsonElement> dictionary)
     {
         _rawData = Enumerable.ToDictionary(dictionary, (e) => e.Key, (e) => e.Value);
-        ;
         _deserializedData = [];
     }
 
@@ -57,7 +56,6 @@ public MultipartJsonDictionary(FrozenDictionary<string, MultipartJsonElement> di
     public MultipartJsonDictionary(MultipartJsonDictionary dictionary)
     {
         _rawData = Enumerable.ToDictionary(dictionary._rawData, (e) => e.Key, (e) => e.Value);
-        ;
         _deserializedData = new(dictionary._deserializedData);
     }
 

src/Orb/Core/MultipartJsonElement.cs

@@ -122,7 +122,6 @@ public static MultipartJsonElement SerializeToElement<T>(
                 (e) => e.Key,
                 (e) => e.Value
             );
-            ;
             return JsonSerializer.Deserialize<T>(element.Json, MultipartSerializerOptions(options));
         }
         finally