Update mpca_lang() example by add null terminated argument#182
Open
bruhtus wants to merge 1 commit intoorangeduck:masterfrom
Open
Update mpca_lang() example by add null terminated argument#182bruhtus wants to merge 1 commit intoorangeduck:masterfrom
bruhtus wants to merge 1 commit intoorangeduck:masterfrom
Conversation
In the current version of mpc parser, we can add NULL add the end of arguments mpca_lang() to indicate that it's the end of argument when trying to find parser and prevent segfault error. This changes update the snippet for the web version and example that use mpca_lang() by adding NULL at the end of mpca_lang() argument.
Author
|
I've been thinking, should we add some explanation about Something like " |
Owner
|
Thanks a lot! I think this was probably the original reason I didn't add it in the first place: it is difficult to explain the purpose of it without getting into the weeds: what is NULL? What are pointers? What are variable argument functions? Why don't they already know the number of arguments they are provided etc. etc. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

First of all, thank you for the book. This book help me a lot when i am trying to learn C, especially looking at the mpc parser source code (even though i still have no idea for the majority of the code 😅).
In the current version of mpc parser, we can add
NULLat the end of arguments mpca_lang() to indicate that it's the end of argument when trying to find parser and prevent segfault error.This changes update the snippet for the web version and example that use mpca_lang() by adding
NULLat the end of mpca_lang() argument.This changes also resolves issue #147.