VM Options support for Notebooks and fixed Enable Preview Option#547
Merged
sid-srini merged 1 commit intooracle:mainfrom Feb 4, 2026
Merged
VM Options support for Notebooks and fixed Enable Preview Option#547sid-srini merged 1 commit intooracle:mainfrom
sid-srini merged 1 commit intooracle:mainfrom
Conversation
sid-srini
reviewed
Jan 27, 2026
Member
sid-srini
left a comment
There was a problem hiding this comment.
Thanks @Achal1607. This is really useful.
nbcode/notebooks/src/org/netbeans/modules/nbcode/java/notebook/NotebookConfigs.java
Show resolved
Hide resolved
nbcode/notebooks/src/org/netbeans/modules/nbcode/java/notebook/NotebookSessionManager.java
Outdated
Show resolved
Hide resolved
nbcode/notebooks/src/org/netbeans/modules/nbcode/java/notebook/NotebookSessionManager.java
Outdated
Show resolved
Hide resolved
nbcode/notebooks/src/org/netbeans/modules/nbcode/java/notebook/NotebookConfigs.java
Show resolved
Hide resolved
nbcode/notebooks/src/org/netbeans/modules/nbcode/java/notebook/NotebookConfigs.java
Outdated
Show resolved
Hide resolved
...e/notebooks/test/unit/src/org/netbeans/modules/nbcode/java/notebook/NotebookConfigsTest.java
Show resolved
Hide resolved
...e/notebooks/test/unit/src/org/netbeans/modules/nbcode/java/notebook/NotebookConfigsTest.java
Show resolved
Hide resolved
…ith EA versions bug and added logger for knowing with which options the kernel is being launched added Notebook config tests for vm options, updated description label for vm options, updated config values flow so that they are set to default if nothing is sent by lsp client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added VM Options config for notebooks, fixed enable preview failing with EA versions bug and added logger for knowing with which options the kernel is being launched.
Closes #539