Fix NetBeans launch failure on unix shell for arguments with quotes et al#314
Open
sid-srini wants to merge 1 commit intooracle:mainfrom
Open
Fix NetBeans launch failure on unix shell for arguments with quotes et al#314sid-srini wants to merge 1 commit intooracle:mainfrom
sid-srini wants to merge 1 commit intooracle:mainfrom
Conversation
…t al Backporting Netbeans PR #7908 (still under review) in order for the LSP server launch to work for launch arguments including the project path containing special characters like quotes, spaces, backticks and $. This is an interim patch to mitigate the effect on user experience, while the upstream PR is under review. It will be updated to the approved patch, as and when it is made available. This is partially related to oracle#301, which only fixes for spaces in arguments. Additionally, the same diff is applied to script/bin/nbcode which is a copy of the netbeans java.lsp.server module's copy. Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
Achal1607
approved these changes
Nov 4, 2024
Member
Achal1607
left a comment
Achal1607
left a comment
There was a problem hiding this comment.
LGTM. I am not very familiar with shell scripts so please @naren2605 if you can have a look then it would be great.
donphelix
approved these changes
Sep 30, 2025
donphelix
left a comment
donphelix
left a comment
There was a problem hiding this comment.
Looks okay to me, just resolve the conflicts and it's good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting Netbeans PR #7908 (still under review) in order for the LSP server launch to work for launch arguments including the project path containing special characters like quotes, spaces, backticks and $.
This is an interim patch to mitigate the effect on user experience, while the upstream PR is under review. It will be updated to the approved patch, as and when it is made available.
This is partially related to #301, which only fixes for spaces in arguments.
Additionally, the same diff is applied to script/bin/nbcode which is a copy of the netbeans java.lsp.server module's copy.