Add filesystem fixes required for UEK 6 images to be built on UEK 7 #9
Open
George-Aeillo wants to merge 1 commit intomainfrom
Open
Add filesystem fixes required for UEK 6 images to be built on UEK 7 #9George-Aeillo wants to merge 1 commit intomainfrom
George-Aeillo wants to merge 1 commit intomainfrom
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
zabdulre
reviewed
Feb 5, 2025
| mkfs.xfs -f -m bigtime=0 -L "$BOOT_PARTITION_LABEL" "$BOOT_DEVICE" | ||
| "mkfs.$FILESYSTEM" -f -L "$ROOT_PARTITION_LABEL" "$ROOT_DEVICE" | ||
| mkfs.xfs -f -m bigtime=0,inobtcount=0,reflink=0 -L "$BOOT_PARTITION_LABEL" "$BOOT_DEVICE" | ||
| "mkfs.$FILESYSTEM" -f -m bigtime=0,inobtcount=0,reflink=0 -L "$ROOT_PARTITION_LABEL" "$ROOT_DEVICE" |
There was a problem hiding this comment.
Does this command work if the filesystem is not xfs?
Author
There was a problem hiding this comment.
Would the filesystem ever not be xfs?
There was a problem hiding this comment.
In the context of format-disk.sh, the filesystem to use is passed in. If it is the case that only xfs is supported then this script could be changed to reflect that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I add fixes to the filesystem creation in ock-forge that allows UEK 6 images to be built on UEK 7 hosts. I have verified that UEK 7 images are allowed to be built with this change as well.