Skip to content

Conversation

@CruzMolina
Copy link
Contributor

@CruzMolina CruzMolina commented Aug 18, 2021

  • feat: initial ICurve contract
  • feat: initial IStakeDao contract
  • feat: initial StakedaoEcrvPricer contract
  • feat: initial StakedaoEcrvPricer deployment script
  • docs: update README w/ StakedaoEcrvPricer deployment steps
  • docs: update docs & diagrams
  • refactor: store underlying as address - StakedaoEcrvPricer
  • refactor: streamline scaling underlying price, update code comments

@CruzMolina CruzMolina requested a review from aparnakr August 18, 2021 15:04
Comment on lines 9 to 23
function depositAll() external;

function deposit(uint256 amount) external;

function withdrawAll() external;

function withdraw(uint256 _shares) external;

function token() external returns (ERC20Interface);

function balanceOf(address account) external view returns (uint256);

function approve(address spender, uint256 amount) external returns (bool);

function transfer(address recipient, uint256 amount) external returns (bool);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contract is also from the StakeDao templates. I don't think it's a good idea to have a different contract here than what's in the stakedao-master branch in the perp vault templates repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants