Skip to content

Conversation

@CruzMolina
Copy link
Contributor

@CruzMolina CruzMolina commented Jun 5, 2021

  • style: alphabetize hardhat config keys
  • build: add @nomiclabs/hardhat-ethers @nomiclabs/hardhat-waffle & ethereum-waffle as devDependencies
  • build: configure hardhat config for deployments
  • build: port truffle migrations to hardhat deployment script, update npm deployment scripts
  • build: use dotenv/config for hardhat env vars

Copy link
Contributor

@antoncoding antoncoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, glad to see us moving to hardhat.
Do u want to convert the tests in the build/hardhat-compile branch too?

@CruzMolina CruzMolina force-pushed the build/hardhat-deployments branch from 873e800 to 8bb8ea9 Compare June 7, 2021 17:39
@CruzMolina
Copy link
Contributor Author

@antoncoding Planning to port over the tests... at some point 😂. For now this PR is intended to switch over migrations to deployments in a non-breaking way.

@haythemsellami
Copy link
Contributor

Do not merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants