Skip to content
This repository was archived by the owner on Mar 21, 2026. It is now read-only.

complete profile card component#167

Open
mbashia wants to merge 17 commits intooptimumBA:profile_card_componentfrom
mbashia:profile_card_component
Open

complete profile card component#167
mbashia wants to merge 17 commits intooptimumBA:profile_card_componentfrom
mbashia:profile_card_component

Conversation

@mbashia
Copy link
Copy Markdown

@mbashia mbashia commented Aug 20, 2024

No description provided.

Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't match the design exactly. There are some alignment issues.

@mbashia mbashia requested a review from almirsarajcic August 23, 2024 02:58
Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the difference?
Screenshot 2024-08-23 at 10 20 32
Screenshot 2024-08-23 at 10 21 07

Comment thread challenges/profile_card_component/tailwind.config.js Outdated
@mbashia mbashia requested a review from almirsarajcic August 27, 2024 12:54
Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the generated screenshots (https://github.com/optimumBA/frontend_mentor_challenges/actions/runs/10578520354)? The mobile one is empty.

Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshots get generated properly now.
Just remove the extra code and that's it.

Comment thread challenges/profile_card_component/tailwind.config.js Outdated
Comment thread .github/workflows/cicd.yml
Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI misbehaves (screenshots). Otherwise, looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants