This repository was archived by the owner on Mar 21, 2026. It is now read-only.
complete profile card component#167
Open
mbashia wants to merge 17 commits intooptimumBA:profile_card_componentfrom
Open
complete profile card component#167mbashia wants to merge 17 commits intooptimumBA:profile_card_componentfrom
mbashia wants to merge 17 commits intooptimumBA:profile_card_componentfrom
Conversation
almirsarajcic
suggested changes
Aug 21, 2024
Member
almirsarajcic
left a comment
There was a problem hiding this comment.
Doesn't match the design exactly. There are some alignment issues.
almirsarajcic
suggested changes
Aug 23, 2024
almirsarajcic
suggested changes
Aug 28, 2024
Member
almirsarajcic
left a comment
There was a problem hiding this comment.
Have you checked the generated screenshots (https://github.com/optimumBA/frontend_mentor_challenges/actions/runs/10578520354)? The mobile one is empty.
almirsarajcic
suggested changes
Sep 12, 2024
almirsarajcic
approved these changes
Sep 13, 2024
Member
almirsarajcic
left a comment
There was a problem hiding this comment.
CI misbehaves (screenshots). Otherwise, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.