Conversation
almirsarajcic
left a comment
almirsarajcic
left a comment
There was a problem hiding this comment.
The tests are failing.
Also, you've committed and pushed some unnecessary files like READMEs, extra images, etc.
almirsarajcic
left a comment
almirsarajcic
left a comment
There was a problem hiding this comment.
The tests are still failing (https://github.com/optimumBA/frontend_mentor_challenges/actions/runs/10369974217/job/28717872421?pr=165). Execute npm run test locally to run the tests.
Files are still in the wrong location, and also there are still some extra files.
My test are passing locally |
|
Let me go through it again, and correct where necessary |
mbashia
force-pushed
the
qr_code_component
branch
from
64bcbe1 to
71e3581
Compare
almirsarajcic
left a comment
almirsarajcic
left a comment
There was a problem hiding this comment.
Much better, but it doesn't match the design exactly (paddings, margins, line height etc.).
https://www.frontendmentor.io/challenges/qr-code-component-iux_sIO_H
Improving this on the next four exercises |
2 participants
No description provided.