Skip to content
This repository was archived by the owner on Mar 21, 2026. It is now read-only.

Chat app css illustration#147

Open
ngumokenneth wants to merge 9 commits intooptimumBA:chat_app_css_illustrationfrom
ngumokenneth:chat_app_css_illustration
Open

Chat app css illustration#147
ngumokenneth wants to merge 9 commits intooptimumBA:chat_app_css_illustrationfrom
ngumokenneth:chat_app_css_illustration

Conversation

@ngumokenneth
Copy link
Copy Markdown

chat_app_css_illustration-desktop
chat_app_css_illustration-mobile

Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big difference between the design proposal and this implementation. Also, images should be inside the challenge directory.

<div class="mt-3">
<a
class="text-optimum-blue hover:text-optimum-darkblue"
href="https://github.com/optimumBA/frontend_mentor_challenges/tree/chat_app_css_illustration/challenges/chat_app_css_illustration"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put your username instead of optimumBA.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. I'll make the changes. Thanks.

Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have some unnecessary file changes.
You shouldn't touch favicons. They aren't a part of challenges.

Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI needs to be improved.

Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI could be improved further.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants