Skip to content
This repository was archived by the owner on Mar 21, 2026. It is now read-only.

Stats preview card component#146

Open
ngumokenneth wants to merge 16 commits intooptimumBA:stats_preview_card_componentfrom
ngumokenneth:stats_preview_card_component
Open

Stats preview card component#146
ngumokenneth wants to merge 16 commits intooptimumBA:stats_preview_card_componentfrom
ngumokenneth:stats_preview_card_component

Conversation

@ngumokenneth
Copy link
Copy Markdown

stats_preview_card_component-desktop
stats_preview_card_component-mobile

Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't match the design. There's so much room for improvement.

The location of the image files is incorrect.

… text, changed the font moved the images directory into the stats_preview_card_component
Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary changes in the diff.

Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have some unnecessary file changes.
You shouldn't touch favicons. They aren't a part of challenges.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants