This repository was archived by the owner on Mar 21, 2026. It is now read-only.
Order summary component#145
Open
ngumokenneth wants to merge 8 commits intooptimumBA:order_summary_componentfrom
Open
Order summary component#145ngumokenneth wants to merge 8 commits intooptimumBA:order_summary_componentfrom
ngumokenneth wants to merge 8 commits intooptimumBA:order_summary_componentfrom
Conversation
ngumokenneth
commented
Oct 8, 2023
ngumokenneth
commented
almirsarajcic
suggested changes
Oct 12, 2023
Member
almirsarajcic
left a comment
almirsarajcic
left a comment
There was a problem hiding this comment.
Location of the image files is wrong and looks completely different than the design.
almirsarajcic
suggested changes
Oct 18, 2023
Member
almirsarajcic
left a comment
almirsarajcic
left a comment
There was a problem hiding this comment.
Design can still be improved, but also the file structure is incorrect. Please take a look at solutions from other developers (other PRs in this repo to see how it should look like).
This is how it looks like in your PR:
And this is how it should look like:
Author
|
sure I'll look into it. Thanks. |
almirsarajcic
suggested changes
Oct 26, 2023
Member
almirsarajcic
left a comment
almirsarajcic
left a comment
There was a problem hiding this comment.
UI needs to be improved.
almirsarajcic
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.