Skip to content
This repository was archived by the owner on Mar 21, 2026. It is now read-only.

Profile card component#144

Open
ngumokenneth wants to merge 18 commits intooptimumBA:profile_card_componentfrom
ngumokenneth:profile_card_component
Open

Profile card component#144
ngumokenneth wants to merge 18 commits intooptimumBA:profile_card_componentfrom
ngumokenneth:profile_card_component

Conversation

@ngumokenneth
Copy link
Copy Markdown

profile_card_component-desktop
profile_card_component-mobile

Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labels font is a little bit different in design and maybe the width of the component.

Comment thread package.json Outdated
Comment thread challenges/profile_card_component/index.html Outdated
Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You need to revert changes to package-lock.json and package.json files, though.

Comment thread package.json Outdated
Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still there.

Copy link
Copy Markdown
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not fixed.
Screenshot 2023-10-26 at 11 44 31

@ngumokenneth ngumokenneth force-pushed the profile_card_component branch from cf49a86 to 8b67c48 Compare October 26, 2023 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants