Rename n_iter to stopping_maxiter

[spline2hg]

This PR renames the bayes_opt iteration parameter from n_iter to stopping_maxiter.

All other parameter names were reviewed and did not require any changes.

Closes #630

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
src/optimagic/optimization/history.py	93.63% <100.00%> (ø)
src/optimagic/optimizers/bayesian_optimizer.py	91.59% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[timmens]

Changes look good, thank you!

Are the failing tests and/or the failing mypy run related to your changes?

[spline2hg]

@timmens the failing ci seems unrelated to my changes. I looked into the mypy issue and it appears a recent update to pandas-stubs (PR #1550) fixed setitem to accept sequences containing None.

This makes the type: ignore at no longer needed and cause an "Unused type ignore" error in CI.

Should I remove the type ignore comment in this PR or create a new PR for it?

[timmens]

Great, thanks! Just do it here!

[spline2hg]

@timmens the test_bntr of pounders testcase is failing, the desired and actual arrays don't match. we have already skipped this test case for Windows and Linux + Python 3.10

Should we skip test_bntr for Python 3.13 as well? or handle it some other way?

[timmens]

This test has been quite annoying for some time. Can you

1. Remove the problematic test-case completely / skip the test if necessary
2. Open an issue so that we can have a deeper look into this at some point

Thank you!

[timmens]

Actually, you don't have to open a new issue, you can simply append it here #657