Skip to content

fix: change podspec template serviceAccount enable and name handling #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nakarin-s wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: change podspec template serviceAccount enable and name handling #11

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb8c021
change podspec template serviceAccount enable and name handling
Jan 30, 2026
e1a0b68
add qoute to sa.name to remove injection vulnerability
nakarin-s Jan 30, 2026
9bae40e
add qoute to sa.name to remove injection vulnerability
nakarin-s Jan 30, 2026
ed82fc7
remove white space
nakarin-s Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/common/templates/_podSpec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ imagePullSecrets:
{{- end }}
securityContext:
{{- toYaml .Values.podSecurityContext | nindent 2 }}
{{- if .Values.serviceAccount }}
serviceAccountName: {{ .Values.serviceAccount }}
{{- if .Values.serviceAccount.create -}}
serviceAccountName: {{ .Values.serviceAccount.name | quote }}
Copy link

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There's an inconsistency in how the service account name is determined. Here, serviceAccountName is set to .Values.serviceAccount.name. However, in charts/common/templates/_serviceaccount.yaml, the service account resource is created with a default name (include "onechart.fullname" .) if .Values.serviceAccount.name is not provided.

If serviceAccount.create is true but serviceAccount.name is empty, a new service account will be created with a generated name, but the pod will be configured to use an empty-named service account, which will fall back to the default service account in the namespace. This will cause the pod to not use the service account created for it.

To ensure the pod uses the correct service account, the logic for determining the name should be consistent. You should use the same default value here.

serviceAccountName: {{ .Values.serviceAccount.name | default (include "onechart.fullname" .) | quote }}

{{- end }}
initContainers:
{{- range .Values.initContainers }}
Expand Down Expand Up @@ -80,4 +80,4 @@ affinity:
tolerations:
{{- toYaml . | nindent 2 }}
{{- end }}
{{- end }}
{{- end }}