Upgrade ty=0.0.8 #723
Upgrade ty=0.0.8 #723
Conversation
WalkthroughThe changes update the pyproject.toml configuration file with two modifications. First, the ty package dependency is upgraded from version 0.0.5 to version 0.0.8. Second, a lint rule override in the tests/** directory configuration is renamed from a previous reference to non-subscriptable to the new name not-subscriptable, maintaining the same linting rule enforcement under the updated naming convention. No changes to public API exports are included in this update. Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
36e2de8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3307a4b5.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-upgrade-ty.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #723 +/- ##
====================================================
+ Coverage 76.28% 76.29% +0.01%
====================================================
Files 114 114
Lines 9830 9831 +1
Branches 1508 1509 +1
====================================================
+ Hits 7499 7501 +2
+ Misses 1837 1834 -3
- Partials 494 496 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-10T17:13:08.136Z
Learnt from: CR
Repo: opsmill/infrahub-sdk-python PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-10T17:13:08.136Z
Learning: Applies to **/*.py : Never bypass type checking without justification
Applied to files:
pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
pyproject.toml (1)
85-85: The ty 0.0.8 upgrade is valid and the package exists on PyPI. No breaking changes or security issues were detected.
| invalid-method-override = "ignore" | ||
| no-matching-overload = "ignore" | ||
| non-subscriptable = "ignore" | ||
| not-subscriptable = "ignore" |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
ty 0.0.8 Python type checker rule names non-subscriptable not-subscriptable
💡 Result:
The rule name is "non-subscriptable". [1]
Sources:
[1] ty rules reference — "non-subscriptable". https://docs.astral.sh/ty/reference/rules/
🏁 Script executed:
# First, let's find and examine the pyproject.toml file to see the configuration context
fd pyproject.tomlRepository: opsmill/infrahub-sdk-python
Length of output: 85
🏁 Script executed:
# Search for references to these rule names in the repository
rg "non-subscriptable|not-subscriptable" --type tomlRepository: opsmill/infrahub-sdk-python
Length of output: 114
🏁 Script executed:
# Read pyproject.toml to check the ty version and rule configuration
cat -n pyproject.toml | sed -n '80,170p'Repository: opsmill/infrahub-sdk-python
Length of output: 3390
🏁 Script executed:
# Also search for the ty dependency specification to confirm the version
rg "ty|pyright" pyproject.toml | head -20Repository: opsmill/infrahub-sdk-python
Length of output: 546
Revert the rule name from not-subscriptable back to non-subscriptable.
The official ty 0.0.8 rule is named non-subscriptable, not not-subscriptable. Using the incorrect name means ty will not recognize or apply this rule configuration. While the naming pattern differs from not-iterable on the next line, the rule name must match the official ty documentation.
🤖 Prompt for AI Agents
In pyproject.toml at line 160, the ty rule name is incorrectly set to
"not-subscriptable"; change it back to the official name "non-subscriptable" so
ty 0.0.8 recognizes and applies the rule—update the key at that line to
"non-subscriptable = \"ignore\"" (keeping the same value) and save the file.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.