Fix list_all_resend_emails: pagination cap, error handling, and empty-result caching#191
Merged
gregv merged 2 commits intofeature/resend-list-emails-apifrom Mar 6, 2026
Merged
Conversation
5 tasks
…ult caching Co-authored-by: gregv <6913307+gregv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Resend List Emails API for recipient-based status lookup
Fix list_all_resend_emails: pagination cap, error handling, and empty-result caching
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three correctness issues in
list_all_resend_emails()addressed based on code review feedback.What does the PR do?
Pagination cap raised +
truncatedflag added:max_pagesincreased from 10 → 100. Uses Python's for-else to settruncated=Trueonly when the cap is actually hit. Flag is stored in Redis and surfaced in all response paths — callers can detect silently incomplete results.Page error handling: Introduced
page_error_occurredflag. On any mid-pagination exception, the function now returnssuccess: Falseand skips caching entirely instead of writing and serving partial data for 5 minutes.Empty-result caching: Removed
if total_fetched > 0guard — empty indexes are now cached with the same 300 s TTL, preventing repeated Resend API calls on accounts with no email history.Type of change
Linked Issue
Make sure you have
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.