fix: Set static pidfile directory

[kumy]

Relates to opnsense/plugins#4260

• patch the ports Makefile to add custom include
• patch the rc script to set a custom static pidfile directory

[fichtner]

Let me think about this. I'm not sure FreeBSD ports will accept this as is.

[kumy]

Hi @fichtner any news? 🙏

[fichtner]

Sorry for dropping this. It's all just not very nice

% git grep client/logs
Makefile:       ${MKDIR} ${STAGEDIR}${WWWDIR}/client/logs
files/xymon-client.in:pidfile="%%WWWDIR%%/client/logs/clientlaunch.`hostname`.pid"
files/xymon-client.in:command_args="--config=%%WWWDIR%%/client/etc/clientlaunch.cfg --log=%%WWWDIR%%/client/logs/clientlaunch.log --pidfile=${pidfile}"
files/xymon-client.in:  chown -R ${xymon_client_user} %%WWWDIR%%/client/logs
pkg-plist:@dir %%WWWDIR%%/client/logs

So apart from the PID file it also wants to push logs into WWWDIR. Would it work if we set WWWDIR=${ETCDIR} and change XYMONTOPDIR to ${PREFIX}/etc/xymon/client ?

Cheers,
Franco

[fichtner]

I'm also not sure if this is really a useful thing to do. The plugin controls the whole config file