Skip to content

nginx: fix HTTP/3 reuseport duplicates #5184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Boubik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nginx: fix HTTP/3 reuseport duplicates #5184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions www/nginx/src/opnsense/service/templates/OPNsense/Nginx/http.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ if cache_path.use_temp_path is defined and cache_path.use_temp_path == '1'
include opnsense_http_vhost_plugins/*.conf;

{% set listen_list = [] %}
{% set http3_reuseport_list = [] %}
{% if OPNsense.Nginx.general.enabled is defined and OPNsense.Nginx.general.enabled == '1' %}
{% for server in helpers.toList('OPNsense.Nginx.http_server') %}
{% set single_servername = server.servername.split(",")[0] %}
Expand Down Expand Up @@ -124,8 +125,14 @@ server {
{% for listen_address in server.listen_https_address.split(',') %}
listen {{ listen_address }} ssl{% if server.proxy_protocol is defined and server.proxy_protocol == '1' %} proxy_protocol{% endif %}{% if server.default_server is defined and server.default_server == '1' %} default_server{% endif %};
{% if server.enable_http3|default("0") == "1" %}
listen {{ listen_address }} quic reuseport{% if server.default_server is defined and server.default_server == '1' %} default_server{% endif %};
{% set listen_address_clean = listen_address.replace(' ', '') %}
{% set listen_address_key = listen_address.replace(' ', '') %}
{% set http3_reuseport = false %}
{% if listen_address_key != '' and listen_address_key not in http3_reuseport_list %}
{% set http3_reuseport = true %}
{% do http3_reuseport_list.append(listen_address_key) %}
{% endif %}
listen {{ listen_address }} quic{% if http3_reuseport %} reuseport{% endif %}{% if server.default_server is defined and server.default_server == '1' %} default_server{% endif %};
{% set listen_address_clean = listen_address_key %}
{% if listen_address_clean != '' %}
{% set listen_port = listen_address_clean.split(':')[-1] %}
{% if listen_port not in http3_alt_svc_ports %}
Expand Down