Open
Conversation
merge with main
differentiate start times removed double arccos fixed raster band index
omega 0.1 -> 0.001 save expected height in cfg add more comments
Contributor
Author
|
The rdr2geo test is currently failing because the DEM interpolator is returning the wrong height. The indices computed by DEM interpolator do not fall within the synthetic DEM so the default value (DEM average) is returned for all points in the radar grid. I think a couple things need addressing:
Since the Cython rdr2geo test tests point by point, it avoids this problem by changing the DEM interpolator default value to expected height per point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based the rdr2geo and geo2rdr unit tests @hfattahi created for the now deprecated Cython ISCE3. All test inputs are generated by the test. The objective for the this PR is have the 4 following tests:
TBD:
Decide whether to use existingUsingSimpleNamespaceto mimicRunConfigshortcut or introduce test yamls and SAFE zip for comprehensiveness.SimpleNamespace.To do: