-
-
Notifications
You must be signed in to change notification settings - Fork 37
feat: added total playlist duration #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
benoit74
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! See inline comments.
Also please do not replace yarn with npm (do not delete yarn.lock and add package-lock.json) ; this needs to be discussed first in a separate issue (and I'm not convinced about the move yet)
And please add an entry to CHANGELOG.md in the "Unreleased" section
|
Hey @benoit74 , really sorry for such a sloppy PR before, I have fixed and refactored my code. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
========================================
- Coverage 0.96% 0.95% -0.02%
========================================
Files 11 11
Lines 1136 1148 +12
Branches 148 150 +2
========================================
Hits 11 11
- Misses 1125 1137 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I believe that the error was because I did not update the cyprus tests for zimui, will fix it asap, sorry for inconvenience. |
|
You also have to fix the QA job: run black, ruff and pyright. Never mind about the integration tests issue, it is a false error only linked to the fact the PR originates from a fork. |
benoit74
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Please squash your commits and rebase to have only one commit on top of latest commit of openzim:main branch and I will merge. We don't want merge commits from main branch to feature branch, it is just a mess in Git. I will merge after that.
|
@benoit74 done! |
|
Hey @benoit74 , just wanted to check in, since this PR been open for a while. |
|
@aaryansinhaa Sorry for the lack on feedback on our side. For the moment @benoit74 is not available, but we don't forget you and he will be back worse case early February to share a feedback. |


Added Playlist duration;
video_channelsto store duration of each video in seconds, used an aggregator and added it to the schema of the playlist.PlaylistViewcomponent andPlaylistPanelcomponent.I have modified the testcases in the
integration_testsand have locally tested. All test cases were passedPlease see the screenshots of the modification in UI for your reference


