Skip to content

feat: add lingui support and vite to openyurt#62

Merged
luc99hen merged 5 commits intoopenyurtio:masterfrom
karanngi:lingui
Jul 15, 2025
Merged

feat: add lingui support and vite to openyurt#62
luc99hen merged 5 commits intoopenyurtio:masterfrom
karanngi:lingui

Conversation

@karanngi
Copy link
Copy Markdown
Contributor

@karanngi karanngi commented Jun 19, 2025

image

karanngi added 2 commits June 19, 2025 03:54
Signed-off-by: karanngi <karann.git@gmail.com>
Signed-off-by: karanngi <karann.git@gmail.com>
@karanngi
Copy link
Copy Markdown
Contributor Author

@luc99hen, which language should be set as the default—Chinese or English?

@luc99hen
Copy link
Copy Markdown
Member

@luc99hen, which language should be set as the default—Chinese or English?

IMO, English is better. @zyjhtangtang @rambohe-ch Any suggestions?

@luc99hen
Copy link
Copy Markdown
Member

luc99hen commented Jul 3, 2025

@karanngi Please fix the eslint check error

Signed-off-by: karanngi <karann.git@gmail.com>
@karanngi
Copy link
Copy Markdown
Contributor Author

karanngi commented Jul 7, 2025

ok

Signed-off-by: karanngi <karann.git@gmail.com>
@karanngi
Copy link
Copy Markdown
Contributor Author

karanngi commented Jul 7, 2025

@luc99hen fixed it — we're now using English as the default language for the codebase.


// Start and run the server
if err := router.Run(":80"); err != nil {
if err := router.Run(":4000"); err != nil {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the exposed port has been changed. The declaration in yaml should also be changed

# OpenYurt Experience Center

This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).
This is the frontend application for the OpenYurt Experience Center, built with Vite + React.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can avoid mentioning the OpenYurt Experience Center as it is a project that has been taken offline.

<meta charset="UTF-8" />
<link rel="icon" type="image/png" href="/OpenYurt.png" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>OpenYurt Experience Center</title>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

Signed-off-by: karanngi <karann.git@gmail.com>
@luc99hen luc99hen merged commit c381dc5 into openyurtio:master Jul 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants