[XProf: trace viewer] Always show delete button for selected time ranges#2317
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
[XProf: trace viewer] Always show delete button for selected time ranges#2317copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
This change ensures that a delete button is always visible for selected time ranges, even when the duration text is too long to fit within the clipped view. The button is centered within the visible portion of the range if the text doesn't fit. The hover area for the delete button is also adjusted to encompass the button and, if present, the duration text. Additionally, deleting a time range now also clears it from the `current_selected_time_range_` if it was the currently selected range. PiperOrigin-RevId: 863687203
copybara-service
bot
force-pushed
the
test_863687203
branch
from
6bd69f7 to
96f24ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[XProf: trace viewer] Always show delete button for selected time ranges
This change ensures that a delete button is always visible for selected time ranges, even when the duration text is too long to fit within the clipped view. The button is centered within the visible portion of the range if the text doesn't fit. The hover area for the delete button is also adjusted to encompass the button and, if present, the duration text. Additionally, deleting a time range now also clears it from the
current_selected_time_range_if it was the currently selected range.