Skip to content

Internal only changes #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Internal only changes #2309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugin/trace_viewer/tf_trace_viewer/tf-trace-viewer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,9 +813,9 @@
`;
},

createPercaleLink: function(hloOp, host) {
createPercaleLink: function(hloOp, hloModule, host) {
if (!this._percaleUrlPrefix || !this._sessionId || !hloOp) return;
const percaleLink = new URL(`${this._percaleUrlPrefix}/static?id=${this._sessionId}&hlo=${hloOp}`);
const percaleLink = new URL(`${this._percaleUrlPrefix}/static?id=${this._sessionId}&hlo=${hloOp}&hlo_module=${hloModule}`);
if (host) {
percaleLink.searchParams.append('host', host);
}
Expand Down Expand Up @@ -892,7 +892,7 @@
this.createCrossToolLink("roofline_model", "Roofline Model", {"roofline_op_name": hloOp}, rooflineText);
const hostnamePrefix = currentProcess.name.split(' ')[0];
const host = this._selectedHosts.find(host => host.startsWith(hostnamePrefix));
this.createPercaleLink(hloOp, host);
this.createPercaleLink(hloOp, hloModule, host);
} else {
// Add crosslink form trace viewer to graph viewer
// per event selection for tensorboard profiler
Expand Down