Intern stack frame construction.#2302
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
copybara-service
bot
force-pushed
the
test_862768899
branch
from
51f51b0 to
8108466
Compare
This allows us to cheaply compare two stack locations for equality, enabling relatively cheap prefix tests. This PR does introduce a couple of functional changes: * we will now drop illegal metadata during parsing or proto deserialization. I tried erroring at first but it turns out people do indeed want to parse serialized HLO with illegal metadata. * we now no longer preserve unreferenced code source metadata during deserialization or parsing. Such metadata will therefore no longer round trip, but it's not clear to me why you would want that. PiperOrigin-RevId: 862768899
copybara-service
bot
force-pushed
the
test_862768899
branch
from
8108466 to
33dde0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intern stack frame construction.
This allows us to cheaply compare two stack locations for equality, enabling relatively cheap prefix tests.
This PR does introduce a couple of functional changes: