Use pkg @ url for local wheel overrides again, instead of --find-links.#40378
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Use pkg @ url for local wheel overrides again, instead of --find-links.#40378copybara-service[bot] wants to merge 1 commit intomainfrom
pkg @ url for local wheel overrides again, instead of --find-links.#40378copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
…inks`. Add a few verbose debug prints, activated by `--repo_env=XLA_PYTHON_REPO_DEBUG=<option string>`. Re-cap: 1. rules_python upgraded 1.7.0 -> 1.8.4\ 0025bf7 * 1.8.4 introduces regression that causes `pkg @ url` lines to be silently dropped/ignored; `--find-links` is used as a workaround 3. `--find-links` itself causes another regression with overrides, fixed in:\ 11a2044 4. rules_python upgraded 1.8.4 -> 1.8.5, which fixes initial regression of `pkg @ wheel` overrides not working\ a70d858 5. *This change* takes advantage of 1.8.5 upgrade and returns to using `pkg @ wheel` PiperOrigin-RevId: 894167271
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
pkg @ urlfor local wheel overrides again, instead of--find-links.Add a few verbose debug prints, activated by
--repo_env=XLA_PYTHON_REPO_DEBUG=<option string>.Re-cap:
0025bf7
pkg @ urllines to be silentlydropped/ignored;
--find-linksis used as a workaround--find-linksitself causes another regression with overrides, fixed in:11a2044
pkg @ wheeloverrides not workinga70d858
pkg @ wheel