[ROCm] Updated compilation_pipeline_rocm.cc#40377
Open
zoranjovanovic-ns wants to merge 1 commit intoopenxla:mainfrom
Open
[ROCm] Updated compilation_pipeline_rocm.cc#40377zoranjovanovic-ns wants to merge 1 commit intoopenxla:mainfrom
zoranjovanovic-ns wants to merge 1 commit intoopenxla:mainfrom
Conversation
github-project-automation
bot
moved this to Pending Google Review
in OpenXLA:GPU - AMD/ROCm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary of Changes
Updated compilation_pipeline_rocm.cc to be aligned with corresponding compiletion.py
🎯 Justification
Using the same layout of Triton passes as triton compiler
🚀 Kind of Contribution
Please remove what does not apply: ♻️ Cleanup
📊 Benchmark (for Performance Improvements)
Please measure and include speedups for one of the public HLOs in
compiler/xla/tools/benchmarks/hlo/.🧪 Unit Tests:
triton/support_test
🧪 Execution Tests:
What execution tests were added? For example, a new optimization should be
tested with an end-to-end execution test triggering the optimization and
asserting correctness. Please provide test cases running with at most 2 GPUs.