PR #40331: [XLA:GPU][oneAPI] Fix build failure in IntelGpuCompiler#40371
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
PR #40331: [XLA:GPU][oneAPI] Fix build failure in IntelGpuCompiler#40371copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
Imported from GitHub PR #40331 00b5900 commit in XLA causes the following failure in oneAPI GPU CI build: ``` ./xla/service/gpu/intel_gpu_compiler.h:57:71: error: non-virtual member function marked 'override' hides virtual member function 57 | const CompileOptions& options, std::optional<int> shard_number) override; | ^ ./xla/service/gpu/gpu_compiler.h:266:48: note: hidden overloaded virtual function 'xla::gpu::GpuCompiler::CompileTargetBinary' declared here: different number of parameters (6 vs 7) 266 | virtual absl::StatusOr<BackendCompileResult> CompileTargetBinary( ``` This PR fixes the failure by updating the function signature of `CompileTargetBinary` to match the base class. Copybara import of the project: -- 63fd38e by Bhavani Subramanian <bhavani1.subramanian@intel.com>: Fix build failure in IntelGpuCompiler::CompileTargetBinary Merging this change closes #40331 FUTURE_COPYBARA_INTEGRATE_REVIEW=#40331 from Intel-tensorflow:bhavanis/oneapi-build-fix 63fd38e PiperOrigin-RevId: 894161828
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #40331: [XLA:GPU][oneAPI] Fix build failure in IntelGpuCompiler
Imported from GitHub PR #40331
00b5900 commit in XLA causes the following failure in oneAPI GPU CI build:
This PR fixes the failure by updating the function signature of
CompileTargetBinaryto match the base class.Copybara import of the project:
--
63fd38e by Bhavani Subramanian bhavani1.subramanian@intel.com:
Fix build failure in IntelGpuCompiler::CompileTargetBinary
Merging this change closes #40331
FUTURE_COPYBARA_INTEGRATE_REVIEW=#40331 from Intel-tensorflow:bhavanis/oneapi-build-fix 63fd38e