[ROCm] Skip unsupported unit tests on MI200#40369
Open
amd-jianli12 wants to merge 2 commits intoopenxla:mainfrom
Open
[ROCm] Skip unsupported unit tests on MI200#40369amd-jianli12 wants to merge 2 commits intoopenxla:mainfrom
amd-jianli12 wants to merge 2 commits intoopenxla:mainfrom
Conversation
Skip multi-pass dot tests for BF16 on MI200 since there's no valid algorithm being returned by hipBlasLt.
github-project-automation
bot
moved this to Pending Google Review
in OpenXLA:GPU - AMD/ROCm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip multi-pass dot tests for BF16 on MI200 since there's no valid algorithm being returned by hipBlasLt.
📝 Summary of Changes
hipBlasLt is returning empty algorithms for multi-pass bf16_bf16_f32 dot configuration on MI200, so disable these tests.
🎯 Justification
This change is to make the following tests pass on MI200 GPU:
//xla/service/gpu:dot_algorithm_support_test_amdgpu_any
//xla/backends/gpu/codegen/triton:dot_algorithms_test_amdgpu_any
🚀 Kind of Contribution
🐛 Bug Fix
@xla-rotation Would you kindly have a look please?