Avoid Decimal objects in number_to_string#1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the performance of playlist serialization by replacing Decimal-based number formatting with a simpler string formatting approach that avoids creating Decimal objects.
Changes:
- Removed the
decimalmodule import and refactorednumber_to_string()to use Python's built-informat()function - Updated
number_to_string()to accept a format specifier parameter for flexibility - Simplified the
StreamInfo.__str__()method to use the updatednumber_to_string()for frame rate formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates playlist serialization such that it avoids creating Python
Decimalobjects.We want this input and output behavior:
We never want exponential notation, even for very small numbers. We do want integer values to look like integers, even if they come in as floats.
This PR:
The performance is 3x better this way. All existing tests pass, and our library of ~900 playlists from the wild show no change.
CC: @wurlced, @bendpham