Skip to content

Conversation

@jefferyto
Copy link
Member

Maintainer: @oskar456
Compile tested: none (cherry picked from #15899)
Run tested: none

Description:
Makefile changes include:

  • Remove USE_UCLIBC, as uclibc is no longer supported

  • Package output modules

  • Move main binary (back) to /usr/sbin, as it is system administration related and requires superuser privileges

New patches:

Init script changes include:

  • Change from explicit disable to explicit enable, so that the service is disabled by default and on first install

  • Set config option default values to default values of the main binary

  • Fix command-line option names and format (from https://forum.openwrt.org/t/cant-start-addrwatch-service/60499/3)

  • Always use the --quiet command-line option, as the procd instance is not configured to capture stdout/stderr

  • Change the syslog config option to start the syslog output module

Signed-off-by: Jeffery To jeffery.to@gmail.com
(cherry picked from commit 31ae85b)

Makefile changes include:

* Remove USE_UCLIBC, as uclibc is no longer supported

* Package output modules

* Move main binary (back) to /usr/sbin, as it is system administration
  related and requires superuser privileges

New patches:

* 003-add-space-for-null-byte.patch - from
  fln/addrwatch@374cfd2

* 004-more-specific-library-linking.patch - from
  fln/addrwatch@27b57d9

* 005-use-c99-format-macro-constants.patch - from
  fln/addrwatch#28

Init script changes include:

* Change from explicit disable to explicit enable, so that the service
  is disabled by default and on first install

* Set config option default values to default values of the main binary

* Fix command-line option names and format (from
  https://forum.openwrt.org/t/cant-start-addrwatch-service/60499/3)

* Always use the --quiet command-line option, as the procd instance is
  not configured to capture stdout/stderr

* Change the syslog config option to start the syslog output module

Signed-off-by: Jeffery To <jeffery.to@gmail.com>
(cherry picked from commit 31ae85b)
@oskar456
Copy link
Contributor

Thank you for your effort!

@neheb neheb merged commit e67f586 into openwrt:openwrt-21.02 Jul 15, 2021
@jefferyto jefferyto deleted the addrwatch-fixes-openwrt-21.02 branch July 16, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants