Conversation
Noltari
approved these changes
Jan 19, 2026
Contributor
|
LGTM |
|
Should the information about receiving a request be logged as |
Contributor
Author
|
I think info is fine there. |
Ok, issue #373 can be closed after merge. |
Logging in dhcpv4_handle_msg() was changed from debug to error during code refactor. Signed-off-by: Paul Donald <newtwen+github@gmail.com> Link: openwrt#375 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Noltari
pushed a commit
to Noltari/odhcpd
that referenced
this pull request
Jan 25, 2026
Logging in dhcpv4_handle_msg() was changed from debug to error during code refactor. (cherry picked from commit 13ef483) Signed-off-by: Paul Donald <newtwen+github@gmail.com> Link: openwrt#375 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
de-escalate error to debug
(was debug prior to refactor)
ping @Alphix @Noltari for a deep review :D