wifi: mt76: add temperature readouts to debugfs #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes makes it possible to read the last actual temperature sensor readout, and temperatures at last VCO and PHY calibations from separate files in debugfs. Previously "mt76/temperature" in debugfs only showed last PHY calibration temperature, not last readout, which was confusing. I'm not sure what the units are supposed to be here. The arithmetic in the code looks suspiciously like conversion from Celsius to Fahrenheit. On a MT7610E (TP-Link Archer C20 v1) I get read outs of around 82-86 while an IR thermometer on the actual chip shows around 30 degrees Celsius, so it roughly makes sense that it's in degrees Fahrenheit. In any case, the resolution of the readout isn't that great, only roughly 2 degrees Celsius/4 degrees Fahrenheit. Signed-off-by: Tomaz Solc <tomaz.solc@tablix.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes makes it possible to read the last actual temperature sensor readout, and temperatures at last VCO and PHY calibations from separate files in debugfs.
Previously "mt76/temperature" in debugfs only showed last PHY calibration temperature, not last readout, which was confusing.
I'm not sure what the units are supposed to be here. The arithmetic in the code looks suspiciously like conversion from Celsius to Fahrenheit. On a MT7610E (TP-Link Archer C20 v1) I get read outs of around 82-86 while an IR thermometer on the actual chip shows around 30 degrees Celsius, so it roughly makes sense that it's in degrees Fahrenheit.
In any case, the resolution of the readout isn't that great, only roughly 2 degrees Celsius/4 degrees Fahrenheit.