wifi: mt76: mt7925: fix key removal failure during MLO roaming #1037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During MLO roaming, mac80211 may request key removal after the link state
has already been torn down. The current code dereferences
mlink->wcidwithout checking if mlink is NULL, causing crashes or -EINVAL errors.
This is a race condition where:
mt792x_vif_to_bss_conf()or related functions return NULLThe fix adds NULL checks for
link_conf,mconf, andmlink. When removinga key (
cmd != SET_KEY), if the link state is already gone, return success(0) instead of error - the key is effectively removed when the link was
torn down.
This prevents the following errors during roaming:
And the associated wpa_supplicant warnings:
Related: #1036
Testing: Tested on Framework Desktop with MT7925 WiFi during overnight roaming stress test.