wifi: mt76: mt792x: fix NULL pointer dereference in TX path #1033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRITICAL FIX
This patch fixes a NULL pointer dereference bug in
mt792x_tx()that can causekernel crashes when transmitting packets during MLO link removal.
Affects both MT7921 and MT7925 drivers since mt792x_core.c is shared.
The Bug
mt792x_sta_to_link()can return NULL during link removal, but there was nocheck before dereferencing.
Also, RCU-dereferenced
confandlink_stapointers were used withoutNULL validation.
Race Condition
mt7925_mac_link_sta_remove)mt792x_sta_to_link()returns NULL for the removed linkwcid = &mlink->wciddereferenceFix
mlinkreturn value before dereferencingwcidconfandlink_stabefore useTesting
Tested on Framework Desktop (AMD Ryzen AI Max 300 Series) with MT7925 WiFi.
Related PRs